Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close #318 #291 #323

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

close #318 #291 #323

wants to merge 3 commits into from

Conversation

shajoezhu
Copy link
Contributor

Pull Request

Fixes #nnn

@shajoezhu shajoezhu requested review from edelarua and pawelru and removed request for edelarua January 23, 2025 05:38
@shajoezhu shajoezhu added the sme label Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Unit Tests Summary

  1 files   4 suites   29s ⏱️
 61 tests 40 ✅ 21 💤 0 ❌
106 runs  85 ✅ 21 💤 0 ❌

Results for commit c2fdadd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
metadata 💔 $8.51$ $+1.00$ $0$ $0$ $0$ $0$
rdata 💔 $10.58$ $+1.15$ $0$ $0$ $0$ $0$
row_values 💔 $8.47$ $+2.76$ $+21$ $-21$ $0$ $0$

Results for commit fcf7d23

♻️ This comment has been updated with latest results.

Melkiades
Melkiades approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Joe :)

This was linked to issues Jan 23, 2025
move data regeneration from vignette to data-raw #318
Open
Making updates of the cache as an exported function #291
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

@pawelru pawelru Awaiting requested review from pawelru

@edelarua edelarua Awaiting requested review from edelarua

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move data regeneration from vignette to data-raw Making updates of the cache as an exported function
2 participants
@shajoezhu @Melkiades