Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is changes how redun scripts create and manage the optional temp dir.
Previously the temp dir was created and later removed by the "host" machine. This led to errors using
tempdir=True
on remote tasks. (Issue: #20)With this change, the tempdir creation and removal happens within the shell script that redun generates to wrap the user command. This means it all happens in one place, and the error mentioned above is avoided.
Note- I used the shell scripting pattern mentioned in this stackoverflow to schedule the deletion whenever the script exits. I'm not super confident that this is the best way to do the cleanup, but it seems functional and didn't require me to muck about in
get_wrapped_command()
. Happy to update based on feedback or just leave this here as a simple demo.Cheers!