This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
WIP Compine all #55
Merged
WIP Compine all #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonHaul
suggested changes
Jul 25, 2024
backoffice/config/api_router.py
Outdated
| @@ -17,9 +17,13 @@ | |||
| router.register("users", UserViewSet) | |||
|
|
|||
| # Workflows | |||
| router.register("workflows/authors", AuthorWorkflowViewSet, basename="workflows-authors"), | |||
| router.register( | |||
| "workflows/authors", AuthorWorkflowViewSet, basename="workflows-authors" | |||
There was a problem hiding this comment.
did black find these lines too long? Seems like many files have been simply formatted
| @@ -0,0 +1,10 @@ | |||
| [ | |||
There was a problem hiding this comment.
these fixtures are great additions, that greatly improve quality of live when having to create everything from scratch, thanks!
| @@ -149,6 +149,7 @@ django-elasticsearch-dsl-drf = {git = "https://github.com/cern-sis/django-elasti | |||
| opensearch-dsl = "^2.1.0" | |||
| opensearch-py = "2.6.0" | |||
| djangorestframework-simplejwt = "^5.3.1" | |||
| django-json-widget = "^2.0.1" | |||
There was a problem hiding this comment.
It seems thattThis APP is not being used
| # In order to add custom dependencies or upgrade provider packages you can use your extended image. | ||
| # Comment the image line, place your Dockerfile in the directory where you placed the docker-compose.yaml | ||
| # and uncomment the "build" line below, Then run `docker-compose build` to build the images. | ||
| image: apache/airflow:2.8.3-python3.11 |
There was a problem hiding this comment.
This line should be commented, if we specify a build below
DonHaul
reviewed
Jul 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.