Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json references test PR #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Json references test PR #34

wants to merge 3 commits into from

Conversation

libretto
Copy link
Collaborator

@libretto libretto commented Oct 24, 2024

This update introduces support for JSON schema references using the standard "$ref" tag.

Why this way

The code relies on the deprecated RefResolver functionality, as Karapace currently still uses these resolvers. Using referencing.Registry for references is not compatible with the current Karapace implementation.

Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  key_format.py
  schema_models.py 65, 226, 232
  schema_reader.py 595-605
  schema_registry_apis.py 1019
  src/karapace/backup
  api.py
  cli.py
  src/karapace/protobuf
  serialization.py
  src/karapace/sentry
  sentry_client.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant