Skip to content

Commit

Permalink
test(sidekiq): Assert that redis-url is recorded
Browse files Browse the repository at this point in the history
Signed-off-by: Ferenc Géczi <[email protected]>
  • Loading branch information
Ferenc- committed Dec 7, 2023
1 parent c1ce4bb commit 195996c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/instrumentation/sidekiq-client_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def assert_normal_trace_recorded(job)
assert_equal 'some_random_queue', second_span[:data][:'sidekiq-client'][:queue]
assert_equal 'SidekiqJobOne', second_span[:data][:'sidekiq-client'][:job]
assert_equal "false", second_span[:data][:'sidekiq-client'][:retry]
assert second_span[:data][:'sidekiq-client'][:'redis-url']
assert_equal job['jid'], second_span[:data][:'sidekiq-client'][:job_id]
end

Expand All @@ -106,6 +107,7 @@ def assert_failure_trace_recorded
assert_equal 'some_random_queue', second_span[:data][:'sidekiq-client'][:queue]
assert_equal 'SidekiqJobTwo', second_span[:data][:'sidekiq-client'][:job]
assert_equal "false", second_span[:data][:'sidekiq-client'][:retry]
assert second_span[:data][:'sidekiq-client'][:'redis-url']
assert_equal 'Fail to enqueue job', second_span[:data][:log][:message]
end

Expand Down
3 changes: 3 additions & 0 deletions test/instrumentation/sidekiq-worker_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ def assert_successful_worker_span(worker_span)

assert_equal 'important', worker_span[:data][:'sidekiq-worker'][:queue]
assert_equal 'SidekiqJobOne', worker_span[:data][:'sidekiq-worker'][:job]
assert worker_span[:data][:'sidekiq-worker'][:'redis-url']
assert_equal false, worker_span[:data][:'sidekiq-worker'][:job_id].nil?
end

Expand All @@ -163,6 +164,7 @@ def assert_failed_worker_span(worker_span)

assert_equal 'important', worker_span[:data][:'sidekiq-worker'][:queue]
assert_equal 'SidekiqJobTwo', worker_span[:data][:'sidekiq-worker'][:job]
assert worker_span[:data][:'sidekiq-worker'][:'redis-url']
assert_equal false, worker_span[:data][:'sidekiq-worker'][:job_id].nil?

assert_equal true, worker_span[:data][:'sidekiq-worker'][:error]
Expand All @@ -172,6 +174,7 @@ def assert_failed_worker_span(worker_span)
def assert_client_span(client_span, job)
assert_equal :'sidekiq-client', client_span[:n]
assert_equal 'important', client_span[:data][:'sidekiq-client'][:queue]
assert client_span[:data][:'sidekiq-client'][:'redis-url']
assert_equal job.name, client_span[:data][:'sidekiq-client'][:job]
end
end

0 comments on commit 195996c

Please sign in to comment.