-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Never ending black screen + some error #30
Comments
I did the same thing as you; i suspect that this plugin currently doesnt work... |
same issue. only just downloaded the plugin yesterday and it worked fine for about 2 hours then infinite loading |
Yeah, this extension blocks most Twitch streams from loading. I found a handful of streams I tried out that do work, but most do not. Disabling the extension allows streams to load again, but Twitch has found a way to bypass both Ublock Origin and AdBlock Plus, because once this extension is disabled, I get ads. |
I've tested locally and this issue is fixed by pull request #29. Would be great if we can get it merged. |
@dotnetdan I know you're not the project maintainer but do you know if any one is doing a build? |
Hi. Here's a installable xpi (remove .zip from file name) if of any help : |
this is now fixed in ublock official update |
Any chance somebody can provide a crx build as well,or get that stuff merged already? Really wish somebody could find a way to influence change to make the ads not interrupt the stream playback but instead play alongside the stream so as to not interrupt it so you don't end up missing anything. |
Twitch is super determined to make people watch ads. We're now back to this addon not working (streams never load past the black screen with this enabled) and ads are bypassing Ublock/ABP again. I've never seen a turn around this quick. |
@JasperKazai As mentioned in this issue, #29 fixes the issue with loading streams. A big issue for me is that the current implementation will strip ALL segments when there are ANY ad segments. This means a couple of things:
Additionally there's no indicator on screen that the extension is in the process of stripping ads. Some text at the top of the stream would be useful and fairly simple to add. I've made a uBlockOrigin script based on this extension which addresses the above issues, but it misses out on the sequence tracking that this extension uses which I think would break at mid-roll ads https://gist.github.com/pixeltris/ee77c8338d7ebe1b9973dfcc973409d8 @instance01 do you have any intention of continuing to work on this? Or would it be best to fork? |
I wonder if an attempt has been made to replace any and all mid-roll/pre-roll ads via a script with a video that lasts 1 second or even shorter and at super low quality so it loads even faster? Another thing could be to trick it into being a past broadcast then load the stream through that,if possible. |
Detecting and removing ad segments is easy at the moment as they are conveniently tagged. There isn't any need to process the content of the actual video stream. The only issue with removing segments is that it messes with the player sequencing (potentially introducing stuttering / loops), but this should only really be an issue for mid-rolls. Even if they were to implement it perfectly, it would still be detectable as they will still need to flag the start/end time so that the player knows to make the stream/ad clickable so that they can get their money for the click-through. It's extremely unlikely they would ever serve zero engagement ads. The main issue is getting served live segments as quickly as possible. This simply doesn't happen until the server believes it should serve you the actual live stream, it doesn't matter how much you make requests on the m3u8. Maybe a distributed system might work where users are part of a network and share live .ts files where available (as not everyone is served ads in the same way). This would need to be done on a per-stream basis obviously. |
@pixeltris best to fork. I'm currently loaded with a few other projects. Also, I've stopped watching Twitch for quite some time now. If anyone likes to maintain a fork, I will link to it in the Readme. |
Hey, I think twitch found a work around for ublock origin because it stopped working for me last night. I found this and tried it out but the screen stays black with a loading symbol in the middle and never ends up showing the stream (tried waiting ~5 minutes)
I'm not sure if this is related but when I view my extensions, I noticed the extension had errors and it were these:
The text was updated successfully, but these errors were encountered: