Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slow down event spamming in main loop #104

Closed
wants to merge 3 commits into from

Conversation

uvera
Copy link
Contributor

@uvera uvera commented May 2, 2021

Should fix #25

Event amount might need to be adjusted.

@uvera uvera force-pushed the event-spamming branch from f27d9dc to 628b77f Compare May 2, 2021 23:22
@uvera uvera changed the title prevent event spamming in main loop slow down event spamming in main loop May 2, 2021
@con-f-use con-f-use added the enhancement New feature or request label May 2, 2021
@con-f-use con-f-use requested a review from paperbenni May 2, 2021 23:25
@uvera
Copy link
Contributor Author

uvera commented May 3, 2021

The optimal event queue value with #105 merged is around 125 events instead of 250

@uvera uvera force-pushed the event-spamming branch from d5a1cec to 628b77f Compare May 3, 2021 17:51
@paperbenni
Copy link
Member

Is there an instance when this would be needed when we have?
#105

@uvera uvera force-pushed the event-spamming branch from 5dfdc23 to 8136222 Compare May 6, 2021 11:17
@con-f-use
Copy link
Member

The optimal event queue value with #105 merged is around 125 events instead of 250

Doesn't the optimal event rate depend a bit on the hardware you're running on?

@uvera
Copy link
Contributor Author

uvera commented May 6, 2021

Is there an instance when this would be needed when we have?
#105

Try spamming summon terminal, the meta + enter keybind

@uvera
Copy link
Contributor Author

uvera commented May 6, 2021

The optimal event queue value with #105 merged is around 125 events instead of 250

Doesn't the optimal event rate depend a bit on the hardware you're running on?

I've no clue to be honest, I've no low performance devices to test that

@uvera uvera force-pushed the event-spamming branch from 8136222 to e5de102 Compare May 6, 2021 11:45
@uvera
Copy link
Contributor Author

uvera commented May 6, 2021

Everything seems fine with master changes, this patchset not needed anymore and it's less preferred over the master branch changes due to buggy nature of this implementation.

@uvera uvera closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay animation queue makes WM unusable.
3 participants