Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named optional parameters to smoketest.sh #300

Open
JamesKunstle opened this issue Oct 23, 2024 · 0 comments
Open

Add named optional parameters to smoketest.sh #300

JamesKunstle opened this issue Oct 23, 2024 · 0 comments

Comments

@JamesKunstle
Copy link
Contributor

This is a little confusing. We have FSDP as the default, so I can use smoketest.sh as-is. But if I want to set the number of GPUs, do I also have to specify FSDP? Since it is the "second positional argument"? Will it break if I just do smoketest.sh 8? We may want to instead just have like --backend/-b and --num-gpus/-n

Originally posted by @Maxusmusti in #280 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant