Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaudi: conflicting accelerate requirement with optimum-habana. #309

Closed
tiran opened this issue Oct 29, 2024 · 5 comments
Closed

Gaudi: conflicting accelerate requirement with optimum-habana. #309

tiran opened this issue Oct 29, 2024 · 5 comments
Assignees

Comments

@tiran
Copy link
Contributor

tiran commented Oct 29, 2024

PR #213 added accelerate>=0.34.2 to instructlab.training. The version requirements conflicts with optimum-habana's version range for accelerate. Version 0.13 and latest version 0.14 require "accelerate >= 0.33.0, < 0.34.0`. Would it be possible to change the lower version range for HPU?

Blocks: #294

@tiran
Copy link
Contributor Author

tiran commented Oct 29, 2024

@JamesKunstle please take a look

@JamesKunstle
Copy link
Contributor

To solve this we'd have a separate requirements-hpu.txt file correct? That'd be fine for builds. We may also not require accelerate for Gaudi if accelerate doesn't support training on Gaudi cards with the pytorch bridge requirements.

@JamesKunstle
Copy link
Contributor

@tiran Opened a PR for this: #320

@JamesKunstle
Copy link
Contributor

@tiran I think this is solved. Would you please confirm?

@tiran
Copy link
Contributor Author

tiran commented Nov 18, 2024

@JamesKunstle yes, the problem is solved now. The latest wheel collection does not have a conflict.

@tiran tiran closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants