fix(ui-progress,ui-tag): remove onClick prop from Tag when callback i…

…s not provided. Fix Progress dependency mismatch (test-locator) Closes: INSTUI-4332
instructure · Nov 20, 2024 · de22f76 · de22f76
1 parent bf9d66d
commit de22f76
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/packages/ui-progress/tsconfig.build.json b/packages/ui-progress/tsconfig.build.json
@@ -17,7 +17,6 @@
     { "path": "../ui-testable/tsconfig.build.json" },
     { "path": "../ui-view/tsconfig.build.json" },
     { "path": "../ui-babel-preset/tsconfig.build.json" },
-    { "path": "../ui-test-locator/tsconfig.build.json" },
     { "path": "../ui-test-utils/tsconfig.build.json" },
     { "path": "../ui-themes/tsconfig.build.json" }
   ]

diff --git a/packages/ui-tag/src/Tag/index.tsx b/packages/ui-tag/src/Tag/index.tsx
@@ -122,7 +122,7 @@ class Tag extends Component<TagProps> {
         as={onClick ? 'button' : 'span'}
         margin={margin}
         type={onClick ? 'button' : undefined}
-        onClick={onClick ?? this.handleClick}
+        {...(onClick && { onClick: this.handleClick })}
         disabled={disabled || readOnly}
         display={undefined}
         title={title || (typeof text === 'string' ? text : undefined)}