docs(ui-buttons): button text changes now announced by screenreaders #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
… examples to make screenreaders announce button text changes Closes: INSTUI-4290, INSTUI-4312, INSTUI-4295
ToMESSKa
force-pushed
the
INSTUI-4290_transition_example_does_not_announce_change_button_text_change_in_screenreader
branch
from
1d5a93c
to
7ae2794
Compare
ToMESSKa
changed the title
matyasf
approved these changes
Nov 21, 2024
joyenjoyer
approved these changes
Nov 21, 2024
ToMESSKa
deleted the
INSTUI-4290_transition_example_does_not_announce_change_button_text_change_in_screenreader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
INSTUI-4290
INSTUI-4312
INSTUI-4295
ISSUE: button text changes in Transition and ToggleDetail examples are not announced by screenreaders
TEST PLAN:
NOTE: unfortuntely putting the aria-live="polite" tag will cause VoiceOver announcing the button text twice. This is a known bug: https://stackoverflow.com/questions/61244988/aria-live-content-read-twice-by-mac-chrome-voiceover After talking about it with Matyi, we concluded it's still better for VoiceOver to read twice and NVDA reading it once than NVDA not reading it at all.