Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation unclear about PR comment functionality vs Deployment status #1204

Open
danielboothcloud opened this issue Jan 7, 2025 · 0 comments

Comments

@danielboothcloud
Copy link

Documentation unclear about PR comment functionality vs Deployment status

Current Behavior

The repository's README shows examples of ArgoCD Commenter providing PR comments when applications sync/fail, but does not clearly document how to enable this functionality.

Documentation Gap

The only documented annotation is:

argocd-commenter.int128.github.io/deployment-url: https://api.github.com/repos/OWNER/REPO/deployments/ID

This appears to be specifically for GitHub Deployments API integration, but there's no clear documentation on:

  1. How to enable basic PR comments without using Deployments API
  2. What annotations (if any) are needed for PR comments
  3. Whether PR comments require GitHub Actions setup

Expected Behavior

Documentation should clearly explain:

  1. The difference between PR comments vs Deployment status features
  2. Required configuration for each feature
  3. Any required annotations and their exact format

Questions

  1. Is PR commenting a supported feature separate from Deployment status?
  2. If so, what configuration/annotations are needed?
  3. If not, should the PR comment examples be clarified as requiring Deployment API integration?

Environment

  • ArgoCD Commenter version: v1.8.0
  • Kubernetes version: 1.28
  • GitHub authentication: GitHub App (configured and working)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant