session-proxy for delegate signing and key storage #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenzi
changed the title
clangenb
reviewed
Nov 29, 2024
| credentials: SessionProxyCredentials<BalanceOf<T>>, | ||
| ) -> DispatchResultWithPostInfo { | ||
| let delegator = ensure_signed(origin)?; | ||
| ensure!(delegator != delegate, Error::<T>::NoSelfProxy); |
There was a problem hiding this comment.
Probably better to call it SelfProxyForbidden
Comment on lines
+185
to
+186
| let signer = self.delegate.clone().unwrap_or(self.getter.sender_account().clone()); | ||
| if self.signature.verify(encoded.as_slice(), &signer) { |
There was a problem hiding this comment.
Suggested change
| let signer = self.delegate.clone().unwrap_or(self.getter.sender_account().clone()); | |
| if self.signature.verify(encoded.as_slice(), &signer) { | |
| let signer = self.delegate.as_ref().unwrap_or(self.getter.sender_account()); | |
| if self.signature.verify(encoded.as_slice(), signer) { |
Comment on lines
+242
to
+243
| let signer = self.delegate.clone().unwrap_or(self.call.sender_account().clone()); | ||
| if self.signature.verify(payload.as_slice(), &signer) { |
There was a problem hiding this comment.
Suggested change
| let signer = self.delegate.clone().unwrap_or(self.call.sender_account().clone()); | |
| if self.signature.verify(payload.as_slice(), &signer) { | |
| let signer = self.delegate.as_ref().unwrap_or(self.call.sender_account()); | |
| if self.signature.verify(payload.as_slice(), signer) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1654
store session key secrets in runtime state and serve them to authenticated owners to allow sessions with less (or no) signing by the owner
send_notetrusted call to allowNonTransferproxies to send notesquestion:
session_proxymay be less intuitive than i.e.delegates. it works very different from frame pallet proxy