VP9 decoder produce video frames whith rendering artifacts #837

angelo-p · 2018-03-23T14:23:04Z

Hello,
I am running with libyami tag 1.2.0-RC1 on an Apollo Lake board 1BN-E ES4.1 and I am seeing a lot of rendering artifacts/frame corruptions when playing vp9 video files.
example test file:
feelings_vp9-640x360.webm

What is the status of the VP9 decoding support?
Would updating to tag 1.3.0-RC1 fix the issue?

Thanks,
Angelo

uartie · 2018-03-23T18:34:51Z

It could be a driver issue. If you are using intel-vaapi-driver (i965), there were several VP9 issues fixed recently (https://github.com/intel/intel-vaapi-driver/issues?utf8=%E2%9C%93&q=is%3Aissue+VP9)

xuguangxin · 2018-03-23T23:08:39Z

@angelo-p , @uartie the vp9 decoder in good shape for a long time, we have 3300+ test clips includes 8/10 bits. We checked decoded frame with libvpx, 99.73% are bit match.
@angelo-p , could you share the stream with us. So we can check what's wrong.
also which driver you used?

angelo-p · 2018-03-23T23:34:29Z

I uploaded the file to my drobbox account.
you can access at:
https://www.dropbox.com/s/cimapj5d0z66kz0/feelings_vp9-640x360.webm?dl=0

we are using intel-vaapi-driver at version 1.8.4
vainfo
libva info: VA-API version 0.40.1
libva info: va_getDriverName() returns 0
libva info: Trying to open /usr/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_0_40
libva info: va_openDriver() returns 0
vainfo: VA-API version: 0.40 (libva 0.40.1)
vainfo: Driver version: Intel i965 driver for Intel(R) Broxton - 1.8.4.pre1 (1.8.4.pre1)
vainfo: Supported profile and entrypoints
VAProfileMPEG2Simple : VAEntrypointVLD
VAProfileMPEG2Main : VAEntrypointVLD
VAProfileH264ConstrainedBaseline: VAEntrypointVLD
VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice
VAProfileH264ConstrainedBaseline: VAEntrypointEncSliceLP
VAProfileH264Main : VAEntrypointVLD
VAProfileH264Main : VAEntrypointEncSlice
VAProfileH264Main : VAEntrypointEncSliceLP
VAProfileH264High : VAEntrypointVLD
VAProfileH264High : VAEntrypointEncSlice
VAProfileH264High : VAEntrypointEncSliceLP
VAProfileH264MultiviewHigh : VAEntrypointVLD
VAProfileH264MultiviewHigh : VAEntrypointEncSlice
VAProfileH264StereoHigh : VAEntrypointVLD
VAProfileH264StereoHigh : VAEntrypointEncSlice
VAProfileVC1Simple : VAEntrypointVLD
VAProfileVC1Main : VAEntrypointVLD
VAProfileVC1Advanced : VAEntrypointVLD
VAProfileNone : VAEntrypointVideoProc
VAProfileJPEGBaseline : VAEntrypointVLD
VAProfileJPEGBaseline : VAEntrypointEncPicture
VAProfileVP8Version0_3 : VAEntrypointVLD
VAProfileVP8Version0_3 : VAEntrypointEncSlice
VAProfileHEVCMain : VAEntrypointVLD
VAProfileHEVCMain : VAEntrypointEncSlice
VAProfileHEVCMain10 : VAEntrypointVLD
VAProfileVP9Profile0 : VAEntrypointVLD

Thanks,
Angelo

chivakker · 2018-03-23T23:48:32Z

FWIW, tried this clip wit libva-2.1.0 and it plays fine.

…

On Fri, Mar 23, 2018 at 4:34 PM, angelo-p ***@***.***> wrote: I uploaded the file to my drobbox account. you can access at: https://www.dropbox.com/s/cimapj5d0z66kz0/feelings_vp9-640x360.webm?dl=0 we are using intel-vaapi-driver at version 1.8.4 vainfo libva info: VA-API version 0.40.1 libva info: va_getDriverName() returns 0 libva info: Trying to open /usr/lib/dri/i965_drv_video.so libva info: Found init function __vaDriverInit_0_40 libva info: va_openDriver() returns 0 vainfo: VA-API version: 0.40 (libva 0.40.1) vainfo: Driver version: Intel i965 driver for Intel(R) Broxton - 1.8.4.pre1 (1.8.4.pre1) vainfo: Supported profile and entrypoints VAProfileMPEG2Simple : VAEntrypointVLD VAProfileMPEG2Main : VAEntrypointVLD VAProfileH264ConstrainedBaseline: VAEntrypointVLD VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice VAProfileH264ConstrainedBaseline: VAEntrypointEncSliceLP VAProfileH264Main : VAEntrypointVLD VAProfileH264Main : VAEntrypointEncSlice VAProfileH264Main : VAEntrypointEncSliceLP VAProfileH264High : VAEntrypointVLD VAProfileH264High : VAEntrypointEncSlice VAProfileH264High : VAEntrypointEncSliceLP VAProfileH264MultiviewHigh : VAEntrypointVLD VAProfileH264MultiviewHigh : VAEntrypointEncSlice VAProfileH264StereoHigh : VAEntrypointVLD VAProfileH264StereoHigh : VAEntrypointEncSlice VAProfileVC1Simple : VAEntrypointVLD VAProfileVC1Main : VAEntrypointVLD VAProfileVC1Advanced : VAEntrypointVLD VAProfileNone : VAEntrypointVideoProc VAProfileJPEGBaseline : VAEntrypointVLD VAProfileJPEGBaseline : VAEntrypointEncPicture VAProfileVP8Version0_3 : VAEntrypointVLD VAProfileVP8Version0_3 : VAEntrypointEncSlice VAProfileHEVCMain : VAEntrypointVLD VAProfileHEVCMain : VAEntrypointEncSlice VAProfileHEVCMain10 : VAEntrypointVLD VAProfileVP9Profile0 : VAEntrypointVLD Thanks, Angelo — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#837 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEOXyakQQQtKyIAkJsNMK817xmjIJaVks5thYaGgaJpZM4S4zVa> .

xuguangxin · 2018-03-26T01:00:56Z

Thanks, @chivakker help to test.@angelo-p could you try latest vaapi and libyami.

thanks

angelo-p · 2018-03-26T18:12:31Z

xuguangxin,

I cannot go to libva-2.1.0.
our graphics group is currently lock with libva-1.8.0

chivakker · 2018-03-26T20:16:49Z

@angelo-p which kernel version are you using? Depending on that you'd need to carry some patches on your environment.

xuguangxin · 2018-03-27T00:42:27Z

if you check driver release notes, no big changes for vp9 decoder.
@chivakker 's point is good, it may related to kernel or something.
@angelo-p, is it possible to try libva 2.0 on your side, It will help us isolate the problem. If it also failed, it appears a kernel issue. If it's ok, maybe you can cherry-pick some patch from libva.

thanks

angelo-p · 2018-06-01T21:07:52Z

@xuguangxin,
we updated libva to version 2.0.0 and I still can see macroblocking issues on the vp9 stream.
see vainfo putput below:
vainfo
libva info: VA-API version 1.1.0
libva info: va_getDriverName() returns 0
libva info: Trying to open /usr/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_1_1
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.1 (libva 2.0.0)
vainfo: Driver version: Intel i965 driver for Intel(R) Broxton - 2.1.1.pre1 (2.1.1.pre1)
vainfo: Supported profile and entrypoints
VAProfileMPEG2Simple : VAEntrypointVLD
VAProfileMPEG2Main : VAEntrypointVLD
VAProfileH264ConstrainedBaseline: VAEntrypointVLD
VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice
VAProfileH264ConstrainedBaseline: VAEntrypointEncSliceLP
VAProfileH264Main : VAEntrypointVLD
VAProfileH264Main : VAEntrypointEncSlice
VAProfileH264Main : VAEntrypointEncSliceLP
VAProfileH264High : VAEntrypointVLD
VAProfileH264High : VAEntrypointEncSlice
VAProfileH264High : VAEntrypointEncSliceLP
VAProfileH264MultiviewHigh : VAEntrypointVLD
VAProfileH264MultiviewHigh : VAEntrypointEncSlice
VAProfileH264StereoHigh : VAEntrypointVLD
VAProfileH264StereoHigh : VAEntrypointEncSlice
VAProfileVC1Simple : VAEntrypointVLD
VAProfileVC1Main : VAEntrypointVLD
VAProfileVC1Advanced : VAEntrypointVLD
VAProfileNone : VAEntrypointVideoProc
VAProfileJPEGBaseline : VAEntrypointVLD
VAProfileJPEGBaseline : VAEntrypointEncPicture
VAProfileVP8Version0_3 : VAEntrypointVLD
VAProfileVP8Version0_3 : VAEntrypointEncSlice
VAProfileHEVCMain : VAEntrypointVLD
VAProfileHEVCMain : VAEntrypointEncSlice
VAProfileHEVCMain10 : VAEntrypointVLD
VAProfileVP9Profile0 : VAEntrypointVLD

I also have a 1920x800 AVC stream that shows some macroblocking issue.
I put the stream at:
https://www.dropbox.com/s/ozzsepl90f6epd1/vobsub_sample.mkv?dl=0
A screenshot exposing the problem is at:
https://www.dropbox.com/s/yvcpwpa9dtr0rqg/screenshot.jpg?dl=0
Can you please take a look?
Thanks,
Angelo

xuguangxin · 2018-06-04T05:11:42Z

Hi @angelo-p ,
Sorry I can't reproduce your issue.
I tried your stream on BXT.

Could you help reproduce my steps.
./tests/yamidecode -i vobsub_sample.mkv -m -2, you will get md5 at output 08dc6f4627328bdd20afe81674ca7b52
ffmpeg -i vobsub_sample.mkv t.yuv && md5sum 5.yuv, you will get md5 08dc6f4627328bdd20afe81674ca7b52
this means the yami's output same as ffmpeg sw output.

my libva version is

commit b3be72a5a110880f70626d7c3bed953cdde124b2
Author: Mark Thompson <[email protected]>
Date:   Thu Apr 26 20:24:32 2018 +0100

    Add missing rate control parameters to trace output

    Signed-off-by: Mark Thompson <[email protected]>

driver version is

commit 40b15a5c6c0103c23a5db810aef27cf75d0b6723
Author: Mark Thompson <[email protected]>
Date:   Wed Apr 25 23:44:33 2018 +0100

    Use f_code to determine max MV length

    The motion vector length is constrained by the level but not set by it -
    we should instead use the f_code values to set the max MV length.

    This fixes encoding when the f_code values are not set to the highest
    allowed for the level, and also adds support for intermediate levels such
    as High 1440 which were not previously handled here.

    Signed-off-by: Mark Thompson <[email protected]>

angelo-p · 2018-06-04T15:44:09Z

Hi @xuguangxin
You are right, I got the same md5:
yamidecode -i /amedia/vobsub_sample.mkv -m -2
libva info: VA-API version 0.40.1
libva info: va_getDriverName() returns 0
libva info: Trying to open /usr/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_0_40
libva info: va_openDriver() returns 0
1426 frame decoded, fps = 30.32. fps after 5 frames = 30.33.
The whole frames MD5:
08dc6f4627328bdd20afe81674ca7b52

xuguangxin · 2018-06-05T04:34:00Z

if you got the same md5, it proves the decoder is good, any bad thing happened in the display?
One thing I should mention, you can't modify the output frame, we will use output frame as a reference for future frames

angelo-p · 2018-06-08T16:10:16Z

Hi xuguangxin,
Can you explain what you mean by "you can't modify the output frame" ?
We are using libyami External Allocator scheme and as long as libyami call the putSurface() callback, our software will release to our surface pool for reuse the output frame as soon as it has been rendered.
Am I correct in assuming that when libyami jas called the putSurface callback, our software is free to do whatever it want with the just release surface ?
Thanks,
Angelo

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VP9 decoder produce video frames whith rendering artifacts #837

VP9 decoder produce video frames whith rendering artifacts #837

angelo-p commented Mar 23, 2018

uartie commented Mar 23, 2018

xuguangxin commented Mar 23, 2018

angelo-p commented Mar 23, 2018

chivakker commented Mar 23, 2018 via email

xuguangxin commented Mar 26, 2018

angelo-p commented Mar 26, 2018

chivakker commented Mar 26, 2018

xuguangxin commented Mar 27, 2018

angelo-p commented Jun 1, 2018

xuguangxin commented Jun 4, 2018

angelo-p commented Jun 4, 2018

xuguangxin commented Jun 5, 2018

angelo-p commented Jun 8, 2018

VP9 decoder produce video frames whith rendering artifacts #837

VP9 decoder produce video frames whith rendering artifacts #837

Comments

angelo-p commented Mar 23, 2018

uartie commented Mar 23, 2018

xuguangxin commented Mar 23, 2018

angelo-p commented Mar 23, 2018

chivakker commented Mar 23, 2018 via email

xuguangxin commented Mar 26, 2018

angelo-p commented Mar 26, 2018

chivakker commented Mar 26, 2018

xuguangxin commented Mar 27, 2018

angelo-p commented Jun 1, 2018

xuguangxin commented Jun 4, 2018

angelo-p commented Jun 4, 2018

xuguangxin commented Jun 5, 2018

angelo-p commented Jun 8, 2018