-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Graph] Enable Graphs with L0 immediate command-list #12279
Conversation
Updates e2e tests to test L0 immediate command-lists. Improves filecheck usage in graph E2E tests Removes test that checks immediate command-list exception Updates the spec. Addresses Issue: intel#10467
Noting that if either of these two PRs merge before this:
Then this PR will need updated so that the new E2E tests introduced use the same method of setting immediate command lists |
set(UNIFIED_RUNTIME_REPO "https://github.com/bensuo/unified-runtime.git") | ||
set(UNIFIED_RUNTIME_TAG maxime/imm-cmd-list-support) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update target UR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will be updated as soon as the UR PR is merged to the main branch.
oneapi-src/unified-runtime#1218 has merged, please update the tag @mfrancepillois |
@intel/llvm-gatekeepers could you please merge this PR? |
@mfrancepillois Seems we have a lot of post-commit fails in Graph tests on Arc. Can you take a look? If they cannot be fixed quickly I recommend reverting this PR
|
Hi @sarnex, I'm already in touch with @mfrancepillois, we will follow up with a PR marking those tests unsupported on specific hardware, while the reason for the failure is investigated. |
@sommerlukas Great thank you!!! |
The PR to disable the tests temporarily is here: #12648 |
After PR #12279, the USM tests fail in post-commit CIs (https://github.com/intel/llvm/actions/runs/7814201804/job/21315560479). We temporarily disable these tests during the bug investigation.
The PR #12677 (linked to the UR PR oneapi-src/unified-runtime#1328 ) fixes the bug. |
Updates e2e tests to test L0 immediate command-lists.
Improves filecheck usage in graph E2E tests
Removes test that checks immediate command-list exception.
Updates the spec.
Addresses Issue: #10467