[SYCL][Graph] Fix post-commit CI after PR #11472 #12362
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore unused `Size` parameter from `memory_manager::ext_oneapi_fill_cmd_buffer`. This was introduced in PR intel#11472 and passed as `Req->MMemoryRange` from the command-group requirement but not used for calling the underlying UR function, leading to a `-Wunused-parameter` error. It may be that this is needed to support buffers of dimension greater than 1, which there are currently no graphs tests for. This will be investigated as a follow-up once post-commit CI is unblocked with this PR.
EwanC
force-pushed
the
ignore_unused_fill_param
branch
from
c5f2924 to
cd611f1
Compare
aelovikov-intel
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore unused
Sizeparameter frommemory_manager::ext_oneapi_fill_cmd_buffer.This was introduced in PR #11472 and passed as
Req->MMemoryRangefrom the command-group requirement but not used for calling the underlying UR function, leading to a-Wunused-parametererror.It may be that this is needed to support buffers of dimension greater than 1, which there are currently no graphs tests for. This will be investigated as a follow-up once post-commit CI is unblocked with this PR.