Update the kernel_queue_specific::max_num_work_group query
#16051
Conversation
Signed-off-by: Michael Aziz <[email protected]>
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <[email protected]>
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <[email protected]>
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <[email protected]>
0x12CC
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Michael Aziz <[email protected]>
Signed-off-by: Michael Aziz <[email protected]>
0x12CC
force-pushed
the
root_group_query
branch
from
3597516
to
c559a66
Compare
0x12CC
requested review from
a team and
uditagarwal97
and removed request for
a team
|
@intel/llvm-reviewers-runtime, could you please review this PR? It's done but I have it marked as draft so that the changes to the UR CMake files don't get merged. I'll revert the change in |
| @@ -3941,9 +3941,9 @@ _ZNK4sycl3_V16kernel16get_backend_infoINS0_4info6device15backend_versionEEENS0_6 | |||
| _ZNK4sycl3_V16kernel16get_backend_infoINS0_4info6device7versionEEENS0_6detail20is_backend_info_descIT_E11return_typeEv | |||
| _ZNK4sycl3_V16kernel16get_backend_infoINS0_4info8platform7versionEEENS0_6detail20is_backend_info_descIT_E11return_typeEv | |||
| _ZNK4sycl3_V16kernel17get_kernel_bundleEv | |||
| _ZNK4sycl3_V16kernel19ext_oneapi_get_infoINS0_3ext6oneapi12experimental4info21kernel_queue_specific19max_num_work_groupsEEENS0_6detail34is_kernel_queue_specific_info_descIT_E11return_typeENS0_5queueERKNS0_5rangeILi1EEEm | |||
There was a problem hiding this comment.
Are the changes in this PR ABI breaking? If so, we would have to put them under the preview-breaking-flag.
There was a problem hiding this comment.
Additions are NOT breaking changes.
There was a problem hiding this comment.
Additions are NOT breaking changes.
There are removals as well below this.
There was a problem hiding this comment.
The removed symbols are related to the old root group query. This query is not part of our extension documentation and never worked. I understood it was okay to remove this old query now since the root group extension is labelled experimental.
|
@uditagarwal97, thanks for the review. Could you please approve this PR or request any changes you need me to make? We won't be able to merge oneapi-src/unified-runtime#2316 until this PR is approved. |
Update calls to
urKernelSuggestMaxCooperativeGroupCountExpto match the changes in oneapi-src/unified-runtime#2316. This PR also implements therange<1>andrange<2>overloads of theext_oneapi_get_infoAPI from sycl_ext_oneapi_launch_queries.