Skip to content
This repository has been archived by the owner on Aug 5, 2022. It is now read-only.

Commit

Permalink
Merge pull request #370 from dawagner/cmake-compile-options
Browse files Browse the repository at this point in the history
CMake: Use add_compile_options when applicable
  • Loading branch information
dawagner committed May 18, 2016
2 parents 5437d88 + a9e5b15 commit 320b4c1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ if(WIN32)
# and thus are not to be used by the client. A better fix would be to export
# only public methods instead of the whole class, but they are too many to
# do that. A separated plugin interface would fix that.
set_property(DIRECTORY PROPERTY COMPILE_OPTIONS /W4 /FIiso646.h -wd4127 -wd4251)
add_compile_options(/W4 /FIiso646.h -wd4127 -wd4251)

# FIXME: Once we have removed all warnings on windows, add the /WX flags if
# FATAL_WARNINGS is enabled
else()
set_property(DIRECTORY PROPERTY COMPILE_OPTIONS -Wall -Wextra -Wconversion -Wno-sign-conversion
add_compile_options(-Wall -Wextra -Wconversion -Wno-sign-conversion
$<$<BOOL:FATAL_WARNINGS>:-Werror>)
endif()

Expand Down

0 comments on commit 320b4c1

Please sign in to comment.