Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Redeem does not crash immediately when it doesn't detect a Cape #190

Open
goeland86 opened this issue Mar 31, 2019 · 2 comments
Open

Redeem does not crash immediately when it doesn't detect a Cape #190

goeland86 opened this issue Mar 31, 2019 · 2 comments
Assignees

Comments

@goeland86
Copy link
Member

This particular else should make Redeem fail immediately, to clarify why it failed to the user.

self.revision = "0B3A"

@Wackerbarth
Copy link
Contributor

I don't think that your suggestion is the appropriate behavior. Redeem should never "crash". Since it is chosen to use OP as the user interface, when Redeem is not properly configured either because of failure to detect appropriate hardware, or a software misconfiguration, it should still interact with OP and deliver error responses to any commands received.

@goeland86
Copy link
Member Author

Perhaps crashing isn't the right action, but it shouldn't pretend it has a replicape attached to it - as @ThatWileyGuy describes it, it will crash later on. Changing this to crash immediately at least means that a user will see that the cape not being detected is the main reason it failed to start, instead of later when it tries to address an I2C device that isn't present.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants