Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arecorder track selection and gain. #28

Open
wiccy46 opened this issue Oct 24, 2019 · 2 comments
Open

Arecorder track selection and gain. #28

wiccy46 opened this issue Oct 24, 2019 · 2 comments
Labels
enhancement New feature or request feedback wanted
Milestone

Comments

@wiccy46
Copy link
Collaborator

wiccy46 commented Oct 24, 2019

In feature-recorder-improvement, I added a new method to Arecorder named set_tracks(self, tracks, gains). This allows individual tracks selected to be recorded before calling record(), e.g.:

ar.set_tracks(tracks=[0, 2], gains=[-3, -10]) #gain in db

or just with one channel: `ar.set_tracks(tracks=2, gains=-10)

I then added data_float = data_float[:, self.tracks] * self.gains to the callback to actually subset the channels.

I also added to reset the recording mode back to record all track with no volume adjustment.

def reset(self):
        self.tracks = slice(None)
        self.gains = np.ones(self.channels)

Originally, I was thinking to introduce input channel selection in record() but think it is best for user to refined the desired channels first just like it would be done in a DAW.

@wiccy46 wiccy46 added enhancement New feature or request feedback wanted labels Oct 24, 2019
@wiccy46 wiccy46 added this to the 0.3.2 milestone Oct 24, 2019
@wiccy46 wiccy46 modified the milestones: 0.3.2, 0.4.2 Jul 1, 2020
@aleneum
Copy link
Member

aleneum commented Nov 27, 2022

@wiccy46: Has this been solved or should that be moved to for instance 0.5.1?

@wiccy46 wiccy46 removed this from the 0.4.2 milestone Dec 7, 2022
@wiccy46
Copy link
Collaborator Author

wiccy46 commented Dec 7, 2022

This has not been resolved. And unlikely will be in 0.5.1 either. I will just remove the milestone. It is not a critical feature. So I guess it has to wait.

@aleneum aleneum added this to the Backlog milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feedback wanted
Projects
None yet
Development

No branches or pull requests

2 participants