Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite of cmd+config packages using spf13 cobra and viper #67

Merged
merged 14 commits into from
Jul 19, 2024
Merged

Rewrite of cmd+config packages using spf13 cobra and viper #67

merged 14 commits into from
Jul 19, 2024

Conversation

equals215
Copy link
Member

@equals215 equals215 commented Jul 1, 2024 •
edited
Loading

  • Rebuild from scratch the cli with spf13/cobra
  • Add spf13/viper config management
  • Enhance the cli logic and separation of duty

@equals215 equals215 requested a review from CorentinB July 1, 2024 14:14
@equals215 equals215 self-assigned this Jul 1, 2024
@equals215 equals215 added the enhancement New feature or request label Jul 1, 2024
@equals215 equals215 marked this pull request as ready for review July 7, 2024 20:05
@equals215
Copy link
Member Author

@CorentinB you can start to review the PR, the 3 get commands are implemented and the whole flag config is too.
I will open subsequent PRs to add file config support, consul config support and more

CorentinB
CorentinB approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@CorentinB CorentinB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot, but LGTM.

@equals215
Copy link
Member Author

equals215 commented Jul 10, 2024 via email •
edited
Loading

@equals215 equals215 merged commit a179d78 into main Jul 19, 2024
1 check passed
@equals215 equals215 deleted the cli-config-enhancements branch July 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CorentinB CorentinB CorentinB approved these changes

Assignees

@equals215 equals215

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@equals215 @CorentinB