Change i18n rendering for edition_count in lazy work preview (#9708)

* Change variable type for edition count * Revert to if/else and remove variable substitution
internetarchive · Aug 9, 2024 · 46727e2 · 46727e2
1 parent 5302bd9
commit 46727e2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/openlibrary/i18n/messages.pot b/openlibrary/i18n/messages.pot
@@ -4953,11 +4953,12 @@ msgid "Select this work"
 msgstr ""
 
 #: jsdef/LazyWorkPreview.html
-#, python-format
-msgid "%(count)d edition"
-msgid_plural "%(count)d editions"
-msgstr[0] ""
-msgstr[1] ""
+msgid "1 edition"
+msgstr ""
+
+#: jsdef/LazyWorkPreview.html
+msgid "editions"
+msgstr ""
 
 #: languages/index.html
 #, python-format

diff --git a/openlibrary/templates/jsdef/LazyWorkPreview.html b/openlibrary/templates/jsdef/LazyWorkPreview.html
@@ -21,7 +21,10 @@
                 $_('by') <span class="authors">${', '.join(work['author_name'])}</span>
         </span>
         &bull;
-        <span class="edition_count">$ungettext('%(count)d edition', '%(count)d editions', work['edition_count'], count=work['edition_count'])</span>
+        $if work['edition_count'] == 1:
+            <span class="edition_count">$_("1 edition")</span>
+        $else:
+            <span class="edition_count">$work['edition_count'] $_("editions")</span>
         <div class="clear"></div>
     </div>