From 64fb5c6149e39c439f067e7fb6a2b4319bcb4521 Mon Sep 17 00:00:00 2001 From: Oleg Hasjanov Date: Tue, 22 Aug 2023 15:30:19 +0300 Subject: [PATCH] refactoring --- app/interactions/actions/simple_mail_validator.rb | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/interactions/actions/simple_mail_validator.rb b/app/interactions/actions/simple_mail_validator.rb index f2e9a479f8..8d71076027 100644 --- a/app/interactions/actions/simple_mail_validator.rb +++ b/app/interactions/actions/simple_mail_validator.rb @@ -3,9 +3,7 @@ module SimpleMailValidator extend self def run(email:, level:) - local_part, domain = email.split('@') - decoded_domain = Addressable::IDNA.to_unicode(domain) - email = "#{local_part}@#{decoded_domain}" + email = decode_email_punycode(email) result = truemail_validate(email: email, level: level) result = validate_for_a_and_aaaa_records(email) if !result && level == :mx @@ -36,6 +34,12 @@ def output_a_and_aaaa_validation_results(email:, result:, type:) logger.info "Validated #{type} record for #{email}. Validation result - #{result}" end + def decode_email_punycode(email) + local_part, domain = email.split('@') + decoded_domain = Addressable::IDNA.to_unicode(domain) + "#{local_part}@#{decoded_domain}" + end + def logger @logger ||= Rails.logger end