Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate last_needle functionality in Guibot #69

Open
pevogam opened this issue Feb 7, 2025 · 1 comment
Open

Deprecate last_needle functionality in Guibot #69

pevogam opened this issue Feb 7, 2025 · 1 comment
Labels
good first issue Good for newcomers

Comments

@pevogam
Copy link
Member

pevogam commented Feb 7, 2025

This functionality is an early implementation from the time we did not have image logging and could be confusing for newcomers that see both a last_needle and possibly some general image logging. It is also undermaintained with some incorrect type errors.

The best approach around it would be not to drop it entirely but to integrate it in the image logging as a "near minimal verbosity level" that just outputs images on find errors or similar behavior.

@pevogam pevogam added the good first issue Good for newcomers label Feb 7, 2025
@pevogam
Copy link
Member Author

pevogam commented Feb 7, 2025

Best approach so far is not to drop it entirely but to integrate it in the image logging as a "near minimal verbosity level" that just outputs images on find errors or similar behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant