Skip to content

Commit

Permalink
Update startup-tests.yml
Browse files Browse the repository at this point in the history
avoid using a secret for postres password:
- this has no security benefit, as the service is running on localhost for the test runner
- this makes external PRs fail, because they are not allowed to get the secret.
To be reviewed before merge.
  • Loading branch information
eric-intuitem committed May 5, 2024
1 parent 3c7d9ae commit 02dfc85
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/startup-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
image: postgres:14.1
env:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: ${{ secrets.POSTGRES_PASSWORD }}
POSTGRES_PASSWORD: postgres
POSTGRES_DB: postgres
ports: ["5432:5432"]
options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
Expand Down

0 comments on commit 02dfc85

Please sign in to comment.