Prevent assigning parent assets to primary assets (#1302)

intuitem · Jan 3, 2025 · 3288ac1 · 3288ac1
1 parent 1fd9902
commit 3288ac1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/backend/core/views.py b/backend/core/views.py
@@ -382,6 +382,18 @@ class AssetViewSet(BaseModelViewSet):
     ]
     search_fields = ["name", "description", "business_value"]
 
+    def _perform_write(self, serializer):
+        type = serializer.validated_data.get("type")
+        if type == Asset.Type.PRIMARY:
+            serializer.validated_data["parent_assets"] = []
+        serializer.save()
+
+    def perform_create(self, serializer):
+        return self._perform_write(serializer)
+
+    def perform_update(self, serializer):
+        return self._perform_write(serializer)
+
     @action(detail=False, name="Get type choices")
     def type(self, request):
         return Response(dict(Asset.Type.choices))

diff --git a/frontend/src/lib/components/Forms/ModelForm/AssetForm.svelte b/frontend/src/lib/components/Forms/ModelForm/AssetForm.svelte
@@ -106,6 +106,7 @@
 />
 <AutocompleteSelect
 	disabled={data.type === 'PR'}
+	hidden={data.type === 'PR'}
 	multiple
 	{form}
 	options={getOptions({ objects: model.foreignKeys['parent_assets'], self: object })}