Fix stack trace information exposure on library storage failure

intuitem · May 3, 2024 · 6a0c87a · 6a0c87a
1 parent 3f87144
commit 6a0c87a
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/backend/library/views.py b/backend/library/views.py
@@ -27,6 +27,10 @@
     StoredLibrarySerializer,
 )
 
+import structlog
+
+logger = structlog.get_logger(__name__)
+
 
 class StoredLibraryViewSet(BaseModelViewSet):
     parser_classes = [FileUploadParser]
@@ -118,8 +122,9 @@ def upload_library(self, request):
             try:
                 StoredLibrary.store_library_content(content)
             except ValueError as e:
+                logger.error("Failed to store library content", error=e)
                 return HttpResponse(
-                    json.dumps({"error": e}),
+                    json.dumps({"error": "Failed to store library content"}),
                     status=HTTP_422_UNPROCESSABLE_ENTITY,
                 )