Avoid repetition

intuitem · Oct 17, 2024 · 82ba211 · 82ba211
1 parent 4ceed7c
commit 82ba211
Showing 1 changed file with 7 additions and 18 deletions.
diff --git a/backend/core/views.py b/backend/core/views.py
@@ -636,24 +636,13 @@ def duplicate(self, request, pk):
                     justification=scenario.justification,
                 )
 
-                duplicate_related_objects(
-                    scenario,
-                    duplicate_scenario,
-                    duplicate_risk_assessment.project.folder,
-                    "applied_controls",
-                )
-                duplicate_related_objects(
-                    scenario,
-                    duplicate_scenario,
-                    duplicate_risk_assessment.project.folder,
-                    "threats",
-                )
-                duplicate_related_objects(
-                    scenario,
-                    duplicate_scenario,
-                    duplicate_risk_assessment.project.folder,
-                    "assets",
-                )
+                for field in ["applied_controls", "threats",  "assets"] :
+                    duplicate_related_objects(
+                        scenario,
+                        duplicate_scenario,
+                        duplicate_risk_assessment.project.folder,
+                        field,
+                    )
 
                 if (
                     duplicate_risk_assessment.project.folder