From 2fb62028ab7884d11681c664e8edc026ab971f48 Mon Sep 17 00:00:00 2001
From: Mohamed-Hacene <mohamedhacene.b@gmail.com>
Date: Mon, 16 Dec 2024 12:48:58 +0100
Subject: [PATCH] feat: change operational scenario/attack path relationship

---
 backend/ebios_rm/migrations/0001_initial.py   |  9 ++++----
 backend/ebios_rm/models.py                    | 14 ++++++-------
 backend/ebios_rm/serializers.py               |  2 +-
 .../ModelForm/OperationalScenarioForm.svelte  | 21 ++++++++++---------
 frontend/src/lib/utils/crud.ts                |  2 +-
 frontend/src/lib/utils/schemas.ts             |  2 +-
 .../[id=uuid]/+page.svelte                    |  2 +-
 7 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/backend/ebios_rm/migrations/0001_initial.py b/backend/ebios_rm/migrations/0001_initial.py
index 8980b23f0f..9e8778c5f9 100644
--- a/backend/ebios_rm/migrations/0001_initial.py
+++ b/backend/ebios_rm/migrations/0001_initial.py
@@ -354,12 +354,13 @@ class Migration(migrations.Migration):
                     models.TextField(blank=True, verbose_name="Justification"),
                 ),
                 (
-                    "attack_paths",
-                    models.ManyToManyField(
-                        help_text="Attack paths that are pertinent to the operational scenario",
-                        related_name="operational_scenarios",
+                    "attack_path",
+                    models.OneToOneField(
+                        help_text="Attack path that is pertinent to the operational scenario",
+                        related_name="operational_scenario",
                         to="ebios_rm.attackpath",
                         verbose_name="Attack paths",
+                        on_delete=django.db.models.deletion.CASCADE,
                     ),
                 ),
                 (
diff --git a/backend/ebios_rm/models.py b/backend/ebios_rm/models.py
index abc2cdf4cc..0459a2d357 100644
--- a/backend/ebios_rm/models.py
+++ b/backend/ebios_rm/models.py
@@ -418,11 +418,12 @@ class OperationalScenario(AbstractBaseModel, FolderMixin):
         related_name="operational_scenarios",
         on_delete=models.CASCADE,
     )
-    attack_paths = models.ManyToManyField(
+    attack_path = models.OneToOneField(
         AttackPath,
         verbose_name=_("Attack paths"),
-        related_name="operational_scenarios",
-        help_text=_("Attack paths that are pertinent to the operational scenario"),
+        related_name="operational_scenario",
+        help_text=_("Attack path that is pertinent to the operational scenario"),
+        on_delete=models.CASCADE,
     )
     threats = models.ManyToManyField(
         Threat,
@@ -465,11 +466,7 @@ def ref_id(self):
 
     @property
     def gravity(self):
-        gravity = -1
-        for attack_path in self.attack_paths.all():
-            if attack_path.gravity > gravity:
-                gravity = attack_path.gravity
-        return gravity
+        return self.attack_path.gravity
 
     def get_likelihood_display(self):
         if self.likelihood < 0:
@@ -478,6 +475,7 @@ def get_likelihood_display(self):
                 "name": "--",
                 "description": "not rated",
                 "value": -1,
+                "hexcolor": "#f9fafb",
             }
         risk_matrix = self.parsed_matrix
         return {
diff --git a/backend/ebios_rm/serializers.py b/backend/ebios_rm/serializers.py
index 3a052d016b..dad2156958 100644
--- a/backend/ebios_rm/serializers.py
+++ b/backend/ebios_rm/serializers.py
@@ -157,7 +157,7 @@ class OperationalScenarioReadSerializer(BaseModelSerializer):
     str = serializers.CharField(source="__str__")
     ebios_rm_study = FieldsRelatedField()
     folder = FieldsRelatedField()
-    attack_paths = FieldsRelatedField(many=True)
+    attack_path = FieldsRelatedField()
     threats = FieldsRelatedField(many=True)
     likelihood = serializers.JSONField(source="get_likelihood_display")
     gravity = serializers.JSONField(source="get_gravity_display")
diff --git a/frontend/src/lib/components/Forms/ModelForm/OperationalScenarioForm.svelte b/frontend/src/lib/components/Forms/ModelForm/OperationalScenarioForm.svelte
index fc57071272..8dd9c15b50 100644
--- a/frontend/src/lib/components/Forms/ModelForm/OperationalScenarioForm.svelte
+++ b/frontend/src/lib/components/Forms/ModelForm/OperationalScenarioForm.svelte
@@ -72,16 +72,17 @@
 		bind:cachedValue={formDataCache['threats']}
 		label={m.threats()}
 	/>
-	<AutocompleteSelect
-		multiple
-		{form}
-		options={getOptions({
-			objects: model.foreignKeys['attack_paths'],
-			label: 'str'
-		})}
-		field="attack_paths"
-		label={m.attackPaths()}
-	/>
+	{#if context !== 'edit'}
+		<AutocompleteSelect
+			{form}
+			options={getOptions({
+				objects: model.foreignKeys['attack_path'],
+				label: 'str'
+			})}
+			field="attack_path"
+			label={m.attackPath()}
+		/>
+	{/if}
 </div>
 <div
 	class="relative p-2 space-y-2 rounded-md {activeActivity === 'two'
diff --git a/frontend/src/lib/utils/crud.ts b/frontend/src/lib/utils/crud.ts
index b413e40f24..74b28bdbc9 100644
--- a/frontend/src/lib/utils/crud.ts
+++ b/frontend/src/lib/utils/crud.ts
@@ -693,7 +693,7 @@ export const URL_MODEL_MAP: ModelMap = {
 			{ field: 'ebios_rm_study', urlModel: 'ebios-rm' },
 			{ field: 'threats', urlModel: 'threats' },
 			{
-				field: 'attack_paths',
+				field: 'attack_path',
 				urlModel: 'attack-paths',
 				endpointUrl: 'ebios-rm/attack-paths',
 				urlParams: 'ebios_rm_study=',
diff --git a/frontend/src/lib/utils/schemas.ts b/frontend/src/lib/utils/schemas.ts
index 7872fa503c..d45a34522e 100644
--- a/frontend/src/lib/utils/schemas.ts
+++ b/frontend/src/lib/utils/schemas.ts
@@ -456,7 +456,7 @@ export const AttackPathSchema = z.object({
 
 export const operationalScenarioSchema = z.object({
 	ebios_rm_study: z.string(),
-	attack_paths: z.string().uuid().array(),
+	attack_path: z.string().uuid(),
 	threats: z.string().uuid().optional().array().optional(),
 	description: z.string(),
 	likelihood: z.number().optional().default(-1),
diff --git a/frontend/src/routes/(app)/(internal)/operational-scenarios/[id=uuid]/+page.svelte b/frontend/src/routes/(app)/(internal)/operational-scenarios/[id=uuid]/+page.svelte
index 4a0fedf0ec..0145161407 100644
--- a/frontend/src/routes/(app)/(internal)/operational-scenarios/[id=uuid]/+page.svelte
+++ b/frontend/src/routes/(app)/(internal)/operational-scenarios/[id=uuid]/+page.svelte
@@ -91,7 +91,7 @@
 			<div class="w-full p-4 bg-gray-50 border rounded-md shadow-sm">
 				<h3 class="font-semibold text-lg text-gray-700 flex items-center space-x-2">
 					<i class="fa-solid fa-table text-gray-500 opacity-75"></i>
-					<span>{m.attackPaths()}</span>
+					<span>{m.attackPath()}</span>
 				</h3>
 				<ModelTable
 					backgroundColor="bg-gray-50"