From e4dfcc6576de17dabc589fd05e943e8ffcaa7c09 Mon Sep 17 00:00:00 2001
From: Abderrahmane Smimite <smimite@gmail.com>
Date: Thu, 5 Dec 2024 20:02:31 +0100
Subject: [PATCH] Fix labels and translations

---
 frontend/messages/en.json                              |  5 ++++-
 frontend/messages/fr.json                              |  5 ++++-
 .../(internal)/risk-scenarios/[id=uuid]/+page.svelte   |  2 +-
 .../risk-scenarios/[id=uuid]/edit/+page.svelte         | 10 +++++-----
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/frontend/messages/en.json b/frontend/messages/en.json
index 9d5b87a36..51665084a 100644
--- a/frontend/messages/en.json
+++ b/frontend/messages/en.json
@@ -922,5 +922,8 @@
 	"ebiosWs5_5": "Establish risk monitoring framework",
 	"activity": "Activity",
 	"bringTheEvidences": "Bring the evidences",
-	"bringTheEvidencesHelpText": "If disabled, the object will be duplicated without its evidences"
+	"bringTheEvidencesHelpText": "If disabled, the object will be duplicated without its evidences",
+	"existingControlsHelper": "What do you currently have to manage this risk",
+	"extraControlsHelper": "What will you do to mitigate this risk",
+	"existingContextHelper": "Description of the existing mitigations (this field will be deprecated soon)"
 }
diff --git a/frontend/messages/fr.json b/frontend/messages/fr.json
index 459556a17..a9fed187e 100644
--- a/frontend/messages/fr.json
+++ b/frontend/messages/fr.json
@@ -898,5 +898,8 @@
 	"ebiosWs5_5": "Mettre en place le cadre de suivi des risques",
 	"activity": "Activité",
 	"bringTheEvidences": "Apportez les preuves",
-	"bringTheEvidencesHelpText": "Si désactivé, l'objet sera dupliqué sans ses preuves"
+	"bringTheEvidencesHelpText": "Si désactivé, l'objet sera dupliqué sans ses preuves",
+	"existingControlsHelper": "Que disposez-vous actuellement pour gérer ce risque",
+	"extraControlsHelper": "Que ferez-vous pour atténuer ce risque",
+	"existingContextHelper": "Description des mesures existantes (ce champ sera bientôt obsolète)"
 }
diff --git a/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/+page.svelte b/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/+page.svelte
index 6c48bc573..c48fb9efe 100644
--- a/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/+page.svelte
+++ b/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/+page.svelte
@@ -185,7 +185,7 @@
 	<div class="flex flex-row space-x-4 card px-4 py-2 bg-white shadow-lg justify-between">
 		<div class="flex flex-col w-1/2">
 			<h4 class="h4 font-semibold">{m.residualRisk()}</h4>
-			<p class="text-sm font-semibold text-gray-400">{m.appliedControls()}</p>
+			<p class="text-sm font-semibold text-gray-400">{m.extraAppliedControls()}</p>
 			<ModelTable
 				source={data.tables['risk_scenarios']}
 				hideFilters={true}
diff --git a/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte b/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte
index 0508120fe..c1be10f4b 100644
--- a/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte
+++ b/frontend/src/routes/(app)/(internal)/risk-scenarios/[id=uuid]/edit/+page.svelte
@@ -236,8 +236,8 @@
 									extra_fields: [['folder', 'str']]
 								})}
 								field="existing_applied_controls"
-								label="Existing controls"
-								helpText="Current measures to manage this risk"
+								label={m.existingControls()}
+								helpText={m.existingControlsHelper()}
 							/>
 						</div>
 						<div class="flex items-center justify-center">
@@ -254,7 +254,7 @@
 						{form}
 						field="existing_controls"
 						label="context"
-						helpText="Description of the existing mitigations ( ℹ️ this field will be deprecated soon)"
+						helpText={m.existingContextHelper()}
 						regionContainer="w-1/2"
 						rows={3}
 					/>
@@ -311,8 +311,8 @@
 									extra_fields: [['folder', 'str']]
 								})}
 								field="applied_controls"
-								label="Additional controls"
-								helpText="Extra measures needed to mitigate this risk"
+								label={m.extraAppliedControls()}
+								helpText={m.extraControlsHelper()}
 							/>
 						</div>
 						<div class="flex items-center justify-center">