Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca 210 fix access control model in api #67

Merged
merged 52 commits into from
Feb 23, 2024

Conversation

nas-tabchiche
Copy link
Contributor

No description provided.

@eric-intuitem eric-intuitem force-pushed the CA-210-fix-access-control-model-in-api branch from 948d429 to 241efe2 Compare February 22, 2024 21:38
squash migrations
craate root folder and global objects after migration
add folder to user
simplify IAM model thanks to previous changes
In particular, remove get_permission method
@eric-intuitem eric-intuitem marked this pull request as draft February 23, 2024 00:48
eric-intuitem and others added 4 commits February 23, 2024 01:52
squash migrations
try fix pytest
…ntuitem/ciso-assistant-community into CA-210-fix-access-control-model-in-api
…ssion

Fix regression in assessment forms
nas-tabchiche and others added 12 commits February 23, 2024 19:43
squash migrations
craate root folder and global objects after migration
add folder to user
simplify IAM model thanks to previous changes
In particular, remove get_permission method
squash migrations
try fix pytest
avoid creating root folder, now this is made automatically during migrate.
everybody can view, only admin can add or delete.
@eric-intuitem eric-intuitem marked this pull request as ready for review February 23, 2024 19:09
nas-tabchiche and others added 8 commits February 23, 2024 20:16
squash migrations
craate root folder and global objects after migration
add folder to user
simplify IAM model thanks to previous changes
In particular, remove get_permission method
squash migrations
try fix pytest
everybody can view, only admin can add or delete.
@eric-intuitem eric-intuitem marked this pull request as draft February 23, 2024 21:01
@eric-intuitem eric-intuitem marked this pull request as ready for review February 23, 2024 21:17
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@eric-intuitem
Copy link
Collaborator

Functional tests not yet working

@eric-intuitem eric-intuitem merged commit 58a6702 into main Feb 23, 2024
10 of 11 checks passed
@eric-intuitem eric-intuitem deleted the CA-210-fix-access-control-model-in-api branch February 23, 2024 21:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants