Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make The website work offline by using font-awesome locally #61

Merged
merged 4 commits into from
Feb 25, 2024
Merged

Make The website work offline by using font-awesome locally #61

merged 4 commits into from
Feb 25, 2024

Conversation

monsieurswag
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 21, 2024 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @eric-intuitem
❌ @Monsieur-Swag
You can retrigger this bot by commenting recheck in this Pull Request

@monsieurswag
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@monsieurswag
Copy link
Contributor Author

recheck

Mohamed-Hacene
Mohamed-Hacene approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@Mohamed-Hacene Mohamed-Hacene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

eric-intuitem
eric-intuitem requested changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an interference with package-lock.json.
Shouldn't we use https://www.npmjs.com/package/svelte-fa instead?

@eric-intuitem
update package.json
c9c6fdc 
add fortawesome: npm i @fortawesome/fontawesome-free
@eric-intuitem eric-intuitem self-requested a review February 25, 2024 04:17
eric-intuitem
eric-intuitem requested changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks library import symbol in docker-compose

@eric-intuitem eric-intuitem self-requested a review February 25, 2024 17:30
eric-intuitem
eric-intuitem approved these changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@eric-intuitem eric-intuitem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With last commit it works well

@eric-intuitem eric-intuitem merged commit a8a12d7 into main Feb 25, 2024
7 of 10 checks passed
@eric-intuitem eric-intuitem deleted the make_fontawesome_work_offline branch February 25, 2024 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mohamed-Hacene Mohamed-Hacene Mohamed-Hacene approved these changes

@eric-intuitem eric-intuitem eric-intuitem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monsieurswag @eric-intuitem @Mohamed-Hacene @Monsieur-Swag