New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functional tests #78

Merged

Mohamed-Hacene merged 5 commits into main from Fix-functional-tests

Feb 27, 2024

frontend/src/lib/components/SideBar/navData.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -30,7 +30,12 @@ export const navData = { @@
     					name: 'calendar',
     					fa_icon: 'fa-solid fa-calendar-days',
     					href: '/calendar',
-    					permissions: ['view_event']
+    					permissions: [
+    						'view_securitymeasure',
+    						'view_riskacceptance',
+    						'view_riskassessment',
+    						'view_complianceassessment'
+    					]
     				}
     			]
     		},
@@ Expand Down @@

frontend/tests/functional/nav.test.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -22,6 +22,8 @@ @@
     			'Backup & restore': 'Backup restore'
     		};
+    		const locals = localItems(languageTag());
     		for await (const [key, value] of sideBar.items) {
     			for await (const item of value) {
     				if (item.href !== '/role-assignments') {
@@ Expand All / @@ -30,7 +32,7 @@ @@
     					if (item.name in temporaryPageTitle) {
     						await expect.soft(logedPage.pageTitle).toHaveText([temporaryPageTitle[item.name]]);
     					} else {
-    						await expect.soft(logedPage.pageTitle).toHaveText(localItems(languageTag())[item.name]);
+    						await expect.soft(logedPage.pageTitle).toHaveText(locals[item.name]);
     					}
     				}
     			}
@@ Expand All / @@ -49,7 +51,7 @@ @@
     		await sideBar.profileButton.click();
     		await expect(sideBar.morePanel).toHaveAttribute('inert');
     		await expect(page).toHaveURL('/profile');
     		await expect.soft(logedPage.pageTitle).toHaveText('Profile');
     		await sideBar.moreButton.click();
     		await expect(sideBar.morePanel).not.toHaveAttribute('inert');
@@ Expand Down @@

frontend/tests/utils/page-content.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -110,7 +110,8 @@ export class PageContent extends BasePage { @@
     				? this.page
     						.getByRole('row', { name: value })
     						.filter({ has: this.page.getByText(additional).first() })
-    				: this.page.getByRole('row', { name: value })
+    						.first()
+    				: this.page.getByRole('row', { name: value }).first()
     			: this.page.getByRole('row').first();
     	}
@@ Expand Down @@

frontend/tests/utils/page-detail.ts

-Original file line number
+Diff line change
@@ Expand Up / @@ -69,9 +69,17 @@ export class PageDetail extends BasePage { @@
     		} else {
     			for (const key in values) {
     				if (await this.page.getByTestId(key.replaceAll('_', '-') + '-field-title').isVisible()) {
-    					await expect
+    					if (key === 'lc_status') {
+    						//TODO replace this with a better solution
+    						await expect
     						.soft(this.page.getByTestId(key.replaceAll('_', '-') + '-field-title'))
-    						.toHaveText(new RegExp(key.replaceAll('_', ' '), 'i'));
+    						.toHaveText(new RegExp(key.replaceAll('_', ' ').replace('lc ', ''), 'i'));
+    					}
+    					else {
+    						await expect
+    							.soft(this.page.getByTestId(key.replaceAll('_', '-') + '-field-title'))
+    							.toHaveText(new RegExp(key.replaceAll('_', ' '), 'i'));
+    					}
     					if (this.form.fields.get(key)?.type === FormFieldType.CHECKBOX) {
     						await expect
@@ Expand Down @@

Provide feedback