Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor: prevent rerender on focus loss #398

Closed
wants to merge 2 commits into from
+3 −3
Closed

editor: prevent rerender on focus loss #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d206409
editor: prevent rerender on focus loss
max-moser Aug 6, 2024
e4722a3
tests: replace docker-compose with docker compose
max-moser Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
pip install ".[$EXTRAS]"
pip freeze
docker --version
docker-compose --version
docker compose version
- name: Run tests
run: |
./run-tests.sh
2 changes: 1 addition & 1 deletion ...sts/assets/semantic-ui/js/invenio_requests/timelineCommentEditor/TimelineCommentEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const TimelineCommentEditor = ({
/>
<Container fluid className="ml-0-mobile mr-0-mobile fluid-mobile">
<RichEditor
inputValue={commentContent}
inputValue={() => commentContent}
onEditorChange={(event, editor) => {
setCommentContent(editor.getContent());
}}
Expand Down
2 changes: 1 addition & 1 deletion ...io_requests/assets/semantic-ui/js/invenio_requests/timelineEvents/TimelineCommentEvent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ class TimelineCommentEvent extends Component {
{isEditing ? (
<RichEditor
initialValue={event?.payload?.content}
inputValue={commentContent}
inputValue={() => commentContent}
onEditorChange={(event, editor) => {
this.setState({ commentContent: editor.getContent() });
}}
Expand Down
Loading