From b70c152fcb21b68b5615ccbf933615e8d2a2fc93 Mon Sep 17 00:00:00 2001 From: Fatimah Date: Wed, 20 Sep 2023 14:41:59 +0200 Subject: [PATCH 1/2] fixed search filter name accessibility bug --- .../semantic-ui/js/invenio_search_ui/components/SearchFilters.js | 1 + 1 file changed, 1 insertion(+) diff --git a/invenio_search_ui/assets/semantic-ui/js/invenio_search_ui/components/SearchFilters.js b/invenio_search_ui/assets/semantic-ui/js/invenio_search_ui/components/SearchFilters.js index 612ca9f3..4b79ff70 100644 --- a/invenio_search_ui/assets/semantic-ui/js/invenio_search_ui/components/SearchFilters.js +++ b/invenio_search_ui/assets/semantic-ui/js/invenio_search_ui/components/SearchFilters.js @@ -29,6 +29,7 @@ export class SearchFiltersComponent extends Component { key={filter[0]} filterKey={filter[0]} filterLabel={filter[1].label} + aria-label={filter[1].label} filterValues={filter[1].buckets} currentQueryState={currentQueryState} updateQueryState={updateQueryState} From 4b2289bd615f82a347e83c0365f7db59d7a997cb Mon Sep 17 00:00:00 2001 From: Fatimah Date: Thu, 21 Sep 2023 12:19:58 +0200 Subject: [PATCH 2/2] fixed icon roles --- .../js/invenio_search_ui/components/SearchDropdowns.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/invenio_search_ui/assets/semantic-ui/js/invenio_search_ui/components/SearchDropdowns.js b/invenio_search_ui/assets/semantic-ui/js/invenio_search_ui/components/SearchDropdowns.js index b10252a3..7b76ebf1 100644 --- a/invenio_search_ui/assets/semantic-ui/js/invenio_search_ui/components/SearchDropdowns.js +++ b/invenio_search_ui/assets/semantic-ui/js/invenio_search_ui/components/SearchDropdowns.js @@ -62,7 +62,7 @@ export class DropdownSort extends Component { trigger={ {this.getCurrentlySelectedOption(parsedOptions).text} - + } options={parsedOptions} @@ -126,7 +126,7 @@ export class DropdownFilter extends Component { trigger={ {filterLabel} - + } options={options}