Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installation: include pytest-black #92

Open
slint opened this issue Feb 9, 2023 · 4 comments
Open

installation: include pytest-black #92

slint opened this issue Feb 9, 2023 · 4 comments

Comments

@slint
Copy link
Member

slint commented Feb 9, 2023

Since we're slowly starting to widely use black for code-formatting we could centralise this dependency here as well.

Note: we also have to remove the dependency from all modules and cookiecutter-invenio-module

@utnapischtim
Copy link
Contributor

i think it is a good idea to have the black dependency within pytest-invenio, but this would create in the near future a lot of work to upgrade every package which is using pytest-invenio. (for the note: It is doable, there are scripts to do it.)

@ntarocco
Copy link
Contributor

pytest-black is in, can we close this?

@slint
Copy link
Member Author

slint commented Apr 17, 2023

It's in tests extras, not the base install_requires. That means each module that depends on pytest-invenio has to install it separately.

@slint
Copy link
Member Author

slint commented Apr 17, 2023

I opened #99 with the change. I wouldn't close the issue yet though, since there's some clean-up to do on the dependent modules to remove the pytest-black dependency from their tests extras. Alternative is that we open a separate issue to track the progress of propagating the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants