Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: added toggle and keyboard focus for accordion #217

Merged

Conversation

0einstein0
Copy link
Member

❤️ Thank you for your contribution!

Description

Closes Issue #215

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@0einstein0 0einstein0 linked an issue Sep 29, 2023 that may be closed by this pull request
@0einstein0 0einstein0 force-pushed the Ay11-Accordion-Deposit-Form branch from 91004dc to 5fcae2c Compare September 29, 2023 09:21
{panels.map((panel, index) => (
<React.Fragment key={panel.key}>
<Accordion.Title
active={activeIndex === index}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default active index was removed, can we still set if the accordion is opened or closed on the page load ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we can by changing the state activeIndex, if you set it to -1, on reload the accordions are closed and on 0 they are all open

@zzacharo zzacharo merged commit c4e2530 into inveniosoftware:master Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ay11: Accordions are not accessible
4 participants