Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorMessage: remove content class wrapper #223

Closed
wants to merge 1 commit into from
Closed

ErrorMessage: remove content class wrapper #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/elements/ErrorMessage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ export class ErrorMessage extends Component {
return (
<Message icon {...uiProps}>
{icon && <Icon name={icon} />}
<Message.Content role="alert">
<div role="alert">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small suggestion, wouldn't it be more pratical to fix it in the css instead? Otherwise we implement the message component from semantic ui in conflict with documentation, and each time there is Message.Content used we need to remember no to use it. Fixing the styling would solve it once for all and make it compliant with the documentation

{header && <Message.Header>{header}</Message.Header>}
{content}
<p>{content}</p>
{!_isEmpty(errors) && <FieldErrorList fieldErrors={errors} />}
</Message.Content>
</div>
</Message>
);
}
Expand Down
Loading