-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to zoneinfo from pytz #7645
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7645 +/- ##
==========================================
- Coverage 84.57% 78.66% -5.91%
==========================================
Files 1178 1128 -50
Lines 53710 57695 +3985
Branches 2027 1440 -587
==========================================
- Hits 45425 45386 -39
- Misses 7779 11931 +4152
+ Partials 506 378 -128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nice. Should we also remove pytz from the requirements? |
@SchrodingersGat sadly not, some of our dependencies still depend on it |
I need to figure out why CI works on my machine but not on GH |
This is more complex than initially thought. https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html |
Wow, what a deep dive! |
@matmair it would be great to get this one closed out if you have some time to assign to it :) |
@SchrodingersGat this is more a skill not a time issue ;-) I can look into it after sso and selection lists |
Ok, LMK if you are banging your head against the wall on it! |
We target 3.9 which has zoneinfo for timezone info instead of pytz.