Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to zoneinfo from pytz #7645

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

matmair
Copy link
Member

@matmair matmair commented Jul 13, 2024

We target 3.9 which has zoneinfo for timezone info instead of pytz.

@matmair matmair added security Relates to a security issue refactor labels Jul 13, 2024
@matmair matmair added this to the 0.16.0 milestone Jul 13, 2024
@matmair matmair self-assigned this Jul 13, 2024
Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 3ff48b4
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6745092d1717360008fd9d4c

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (594dc49) to head (3ff48b4).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/InvenTree/helpers.py 60.00% 2 Missing ⚠️
src/backend/InvenTree/report/tests.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7645      +/-   ##
==========================================
- Coverage   84.57%   78.66%   -5.91%     
==========================================
  Files        1178     1128      -50     
  Lines       53710    57695    +3985     
  Branches     2027     1440     -587     
==========================================
- Hits        45425    45386      -39     
- Misses       7779    11931    +4152     
+ Partials      506      378     -128     
Flag Coverage Δ
backend 85.96% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

Nice. Should we also remove pytz from the requirements?

@matmair
Copy link
Member Author

matmair commented Jul 14, 2024

@SchrodingersGat sadly not, some of our dependencies still depend on it

@matmair matmair marked this pull request as draft July 17, 2024 16:34
@matmair
Copy link
Member Author

matmair commented Jul 17, 2024

I need to figure out why CI works on my machine but not on GH

@matmair
Copy link
Member Author

matmair commented Jul 30, 2024

This is more complex than initially thought. https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html
I am amazed we have not had problems with pytz before.

@matmair matmair modified the milestones: 0.16.0, 1.0.0 Jul 30, 2024
@SchrodingersGat
Copy link
Member

Wow, what a deep dive!

@SchrodingersGat
Copy link
Member

@matmair it would be great to get this one closed out if you have some time to assign to it :)

@matmair
Copy link
Member Author

matmair commented Nov 20, 2024

@SchrodingersGat this is more a skill not a time issue ;-) I can look into it after sso and selection lists

@SchrodingersGat
Copy link
Member

Ok, LMK if you are banging your head against the wall on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor security Relates to a security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants