Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add the steps property #781

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

blendthink
Copy link
Contributor

@blendthink blendthink commented Oct 26, 2024

Description

This pull request addresses an issue in the official Melos schema configuration for the melos.yaml file. Specifically, it adds the missing schema definition for the steps field.

Problem

The current official schema lacks the definition for the steps field in melos.yaml. This omission causes validation errors when users attempt to use the steps field in their melos.yaml files.

image

Solution

Add the steps property to the script definition in the $defs.script section of melos.yaml.schema.json.

image

Validation

The changes have been validated in the repository at https://github.com/blendthink/melos-yaml-scheme.

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link

docs-page bot commented Oct 26, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/melos~781

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for your contribution! :)

@spydon spydon enabled auto-merge (squash) October 26, 2024 07:58
@blendthink
Copy link
Contributor Author

@spydon
I submitted a pull request, but some of the CI checks failed.
https://github.com/invertase/melos/actions/runs/11529828753/job/32099370944

It seems that this issue has occurred before as well, and it appears to be a randomly occurring problem.
https://github.com/invertase/melos/actions/runs/11222568392/job/31195282729

I attempted to rerun the CI by creating and pushing an empty commit, but I forgot that it requires maintainer approval.
I apologize for the inconvenience, but could you please help by rerunning the CI?

@spydon spydon merged commit 9681481 into invertase:main Oct 26, 2024
10 checks passed
@blendthink blendthink deleted the chore/add-steps-scheme branch October 26, 2024 08:29
@blendthink
Copy link
Contributor Author

Thank you for rerunning the CI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants