Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket.IO v2 support #155

Open
dpanic opened this issue May 12, 2017 · 6 comments · May be fixed by #158
Open

Socket.IO v2 support #155

dpanic opened this issue May 12, 2017 · 6 comments · May be fixed by #158

Comments

@dpanic
Copy link

dpanic commented May 12, 2017

Hi,

can you tell me will it be possible to make socketIO-client work with socket.io 2.0.1 ( https://github.com/socketio/socket.io/releases ) ?

I think this is the issue -> "uws is now the default Websocket engine".
@Nakroma
Copy link

Nakroma commented May 25, 2017

At least for me, currently creating a SocketIO instance is not working with socket.io 2.x

@oguzhanogreden oguzhanogreden linked a pull request May 26, 2017 that will close this issue
Open
@MisterWil MisterWil mentioned this issue Jun 12, 2017
Open
@artus9033
Copy link

Still not working with v2

@computersrmyfriends
Copy link

+1

@dpanic
Copy link
Author

dpanic commented Jul 30, 2017

What is status of this? Do we have any news?

@willmorgan
Copy link

willmorgan commented Aug 10, 2017 •
edited
Loading

I think this is the issue -> "uws is now the default Websocket engine".

I ran with this and tried setting wsEngine: 'ws' in my server config (this was the previous default),

Sadly, the socketIO-client integration still breaks so I don't think that uws is the root cause.

#158 looks promising as the other breaking change from the JS library was stopping double-decoding of payloads. As this package doesn't seem to be maintained very much, @Nakroma has forked it with the patch.

@eulersson
Copy link

+1 on this.

I don't have privileges to change the socketio version of the backend I am using so I need to use 2.x :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary decode from received package oguzhanogreden/socketIO-client
6 participants
@willmorgan @computersrmyfriends @dpanic @Nakroma @eulersson @artus9033