From 90c104b77f362a690649138954a9619f111e5752 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Tue, 18 Jul 2023 10:22:21 +0300 Subject: [PATCH 1/4] Improve error readability with dark mode --- lib/main.dart | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/main.dart b/lib/main.dart index 64b905a264b..adc4d26bb81 100644 --- a/lib/main.dart +++ b/lib/main.dart @@ -294,6 +294,14 @@ void _registerErrorHandlers() { */ ErrorWidget.builder = (FlutterErrorDetails details) { - return Material(child: Center(child: Text(details.toString()))); + return Material( + color: Colors.grey.shade100, + child: Center( + child: Text( + details.toString(), + style: TextStyle(color: Colors.black), + ), + ), + ); }; } From 1d054e57c64113fd21dfbc3cfa971653a3441cb6 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Tue, 18 Jul 2023 10:32:35 +0300 Subject: [PATCH 2/4] Improve PHP version check --- lib/ui/app/dialogs/health_check_dialog.dart | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ui/app/dialogs/health_check_dialog.dart b/lib/ui/app/dialogs/health_check_dialog.dart index 9bbb6eda07f..dfe928d5881 100644 --- a/lib/ui/app/dialogs/health_check_dialog.dart +++ b/lib/ui/app/dialogs/health_check_dialog.dart @@ -139,7 +139,10 @@ class _HealthCheckDialogState extends State { ), _HealthListTile( title: 'PHP Info', - isValid: _response.phpVersion.isOkay, + // TODO move this logic to the backend + isValid: _response.phpVersion.isOkay && + webPhpVersion.startsWith('8') && + cliPhpVersion.startsWith('8'), subtitle: 'Web: v$webPhpVersion\nCLI: v$cliPhpVersion' + (phpMemoryLimit.isNotEmpty ? '\nMemory Limit: $phpMemoryLimit' From c6c6db2cc91b3331cb2b93cb97e2aa099c3dbcb9 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Tue, 18 Jul 2023 10:37:21 +0300 Subject: [PATCH 3/4] Fix for purge data bug --- lib/redux/app/app_middleware.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/redux/app/app_middleware.dart b/lib/redux/app/app_middleware.dart index fd36a458364..3e827cf1802 100644 --- a/lib/redux/app/app_middleware.dart +++ b/lib/redux/app/app_middleware.dart @@ -587,6 +587,8 @@ Middleware _createClearData( return (Store store, dynamic action, NextDispatcher next) async { companyRepositories.forEach((repo) => repo.delete()); + store.dispatch(PersistData()); + next(action); }; } From f6158074a8742782f679888d7b5fca27fbe963d8 Mon Sep 17 00:00:00 2001 From: Hillel Coren Date: Tue, 18 Jul 2023 10:43:10 +0300 Subject: [PATCH 4/4] Add cancelled invoice filter --- lib/ui/invoice/invoice_screen.dart | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/ui/invoice/invoice_screen.dart b/lib/ui/invoice/invoice_screen.dart index 6c3d3f299cd..806ddab5a32 100644 --- a/lib/ui/invoice/invoice_screen.dart +++ b/lib/ui/invoice/invoice_screen.dart @@ -72,6 +72,11 @@ class InvoiceScreen extends StatelessWidget { ..id = kInvoiceStatusPastDue ..name = localization.pastDue, ), + InvoiceStatusEntity().rebuild( + (b) => b + ..id = kInvoiceStatusCancelled + ..name = localization.cancelled, + ), ]; return ListScaffold(