Skip to content

Commit

Permalink
ci: split jobs into build/check/test
Browse files Browse the repository at this point in the history
Also remove the dependency on xvfb as we don't need a running X server at the moment.
  • Loading branch information
psychedelicious committed Dec 22, 2024
1 parent 0e24869 commit e388bfa
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build Binaries
name: Build Unsigned Binaries

on:
push:
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Run Code Quality Checks

on: [push, workflow_dispatch]

jobs:
check:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Use Node.js 22.x
uses: actions/setup-node@v4
with:
node-version: 22.x
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Run code quality checks
run: npm run lint
12 changes: 2 additions & 10 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Test Electron App
name: Run Tests

on: [push, workflow_dispatch]

Expand All @@ -18,13 +18,5 @@ jobs:
- name: Install dependencies
run: npm ci

- name: Install system dependencies
run: |
sudo apt-get update
sudo apt-get install -y xvfb libgbm-dev
- name: Run tests
run: xvfb-run --auto-servernum npm test

- name: Run code quality checks
run: xvfb-run --auto-servernum npm run lint
run: npm run test:no-watch

0 comments on commit e388bfa

Please sign in to comment.