From e388bfafb8e3f9337464b4bf1c445e1a15116931 Mon Sep 17 00:00:00 2001 From: psychedelicious <4822129+psychedelicious@users.noreply.github.com> Date: Sun, 22 Dec 2024 11:50:47 +1100 Subject: [PATCH] ci: split jobs into build/check/test Also remove the dependency on xvfb as we don't need a running X server at the moment. --- .github/workflows/build.yml | 2 +- .github/workflows/check.yml | 22 ++++++++++++++++++++++ .github/workflows/test.yml | 12 ++---------- 3 files changed, 25 insertions(+), 11 deletions(-) create mode 100644 .github/workflows/check.yml diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6bf5383..299e477 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1,4 +1,4 @@ -name: Build Binaries +name: Build Unsigned Binaries on: push: diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml new file mode 100644 index 0000000..58a73ce --- /dev/null +++ b/.github/workflows/check.yml @@ -0,0 +1,22 @@ +name: Run Code Quality Checks + +on: [push, workflow_dispatch] + +jobs: + check: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v4 + + - name: Use Node.js 22.x + uses: actions/setup-node@v4 + with: + node-version: 22.x + cache: 'npm' + + - name: Install dependencies + run: npm ci + + - name: Run code quality checks + run: npm run lint diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 49aa9fa..c07b055 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,4 +1,4 @@ -name: Test Electron App +name: Run Tests on: [push, workflow_dispatch] @@ -18,13 +18,5 @@ jobs: - name: Install dependencies run: npm ci - - name: Install system dependencies - run: | - sudo apt-get update - sudo apt-get install -y xvfb libgbm-dev - - name: Run tests - run: xvfb-run --auto-servernum npm test - - - name: Run code quality checks - run: xvfb-run --auto-servernum npm run lint + run: npm run test:no-watch