-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
indicator.error is not valid state role #23
Comments
Looking at If ERROR should still be a different thing, then my proposal would be that the role should change to @GermanBluefox what is your opinion? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of the adapter and tell us. Also check that all relevant details, logs and reproduction steps are included and update them if needed. Thank you for your contributions. |
@GermanBluefox ? What do you think? |
I can create a PR for it, if wanted. |
I cannot see any error.xx roles here Possibly this Issue is obolete? |
Yes, that is the problem. There are no indicator.error roles defined, but they are used in type-detector, for example here https://github.com/ioBroker/ioBroker.type-detector/blob/master/index.js#L80 |
OK, sorry - i read the issue the other way round. :-) But I do not see if error.xxx is required. There are maintanance.xxx and alarm.xxx anyway. |
Today I thought I'd create a PR, but I recognized that defaultType for ERROR is 'string'. So it seems to be meant for a error message or something? But that would not fit well with the Any thoughts on this? |
The role indicator.error is not valid.
This is used everywhere here!
https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md#indicators-boolean-read-only
The text was updated successfully, but these errors were encountered: