From 8ae4ee58b311812e8f6fe05f43d867ea66479494 Mon Sep 17 00:00:00 2001 From: Sandip Kakadiya Date: Tue, 24 Nov 2020 18:00:52 +0530 Subject: [PATCH] 1.2.4 release & analyze related changes, changelog updated --- .travis.yml | 1 + CHANGELOG.md | 7 ++++++- example/pubspec.lock | 2 +- lib/components/appbar/gf_appbar.dart | 4 +++- pubspec.yaml | 2 +- test/getflutter_test.dart | 5 ----- 6 files changed, 12 insertions(+), 9 deletions(-) delete mode 100644 test/getflutter_test.dart diff --git a/.travis.yml b/.travis.yml index e2295176..75e85893 100644 --- a/.travis.yml +++ b/.travis.yml @@ -26,3 +26,4 @@ before_script: script: - ./../flutter/bin/flutter analyze . - ./../flutter/bin/cache/dart-sdk/bin/dartfmt --dry-run lib + - ./../flutter/bin/flutter test diff --git a/CHANGELOG.md b/CHANGELOG.md index 0448aa8a..f73b8139 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Changelog -## 1.2.3 - 2020-11-12 +## 1.2.4 - 2020-11-12 ### Fixed * [GFProgressBar] issue. @@ -11,6 +11,11 @@ * [GFCarousel] issue. #185 * Many more minor improvements. +### Added +* Test cases added for couple of components + - GFLoader + - GFTypography + ## 1.2.2 - 2020-10-02 diff --git a/example/pubspec.lock b/example/pubspec.lock index 2fe44bd7..21566b89 100644 --- a/example/pubspec.lock +++ b/example/pubspec.lock @@ -92,7 +92,7 @@ packages: path: ".." relative: true source: path - version: "1.2.3" + version: "1.2.4" matcher: dependency: transitive description: diff --git a/lib/components/appbar/gf_appbar.dart b/lib/components/appbar/gf_appbar.dart index d32582e7..a471efba 100644 --- a/lib/components/appbar/gf_appbar.dart +++ b/lib/components/appbar/gf_appbar.dart @@ -309,7 +309,9 @@ class _GFAppBarState extends State { assert(debugCheckHasMaterialLocalizations(context)); final ThemeData theme = Theme.of(context); final AppBarTheme appBarTheme = AppBarTheme.of(context); - final ScaffoldState scaffold = Scaffold.of(context, nullOk: true); + final ScaffoldState scaffold = Scaffold.of(context); + // final ScaffoldState scaffold =Scaffold.of(context, nullOk: true); + // final ScaffoldState scaffold = Scaffold.maybeOf(context); final ModalRoute parentRoute = ModalRoute.of(context); final bool hasDrawer = scaffold?.hasDrawer ?? false; final bool hasEndDrawer = scaffold?.hasEndDrawer ?? false; diff --git a/pubspec.yaml b/pubspec.yaml index 0dd14f28..27978722 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -1,6 +1,6 @@ name: getwidget description: GetWidget is open source libraries that come with pre-build 1000+ UI components. It makes development faster & more enjoyable. You can customize the component as per your need. -version: 1.2.3 +version: 1.2.4 homepage: https://github.com/ionicfirebaseapp/getwidget environment: diff --git a/test/getflutter_test.dart b/test/getflutter_test.dart deleted file mode 100644 index a8155e2f..00000000 --- a/test/getflutter_test.dart +++ /dev/null @@ -1,5 +0,0 @@ -import 'package:flutter_test/flutter_test.dart'; - -void main() { - test('Simple test', () {}); -}