Add support for images on Google "All" page #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a feature suggested by issue #462, where images in the "All" section of Google Desktop are now supported by the extension.
Here's a demo:
demo-images.webm
Additional Comments
Now with the knowledge from the master, I'm closer to enlightenment...
Jokes aside, thanks for you suggestion to use
pageHandlers
, I was about to go down some weird rabbit hole involving delays andsetTimeout
.By the way, the use of recursion in the following snippet was really clever, my brain got really happy when I understood it LOL.
ublacklist/src/scripts/search-engines/helpers.ts
Lines 308 to 317 in 4a9a5e0