Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add delegation token id #1453

Closed

Conversation

itsyaasir
Copy link
Contributor

Description of change

A quick for the identity move package; currently the build fails because the DelegationToken doesn't have id function.

I opted to use delegation_token_id as a function name as Move doesn't allow using id twice in the same namespace level.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@itsyaasir itsyaasir added the Bug Something isn't working. label Nov 27, 2024
@itsyaasir itsyaasir requested review from wulfraem, UMR1352 and a team November 27, 2024 07:18
@itsyaasir itsyaasir self-assigned this Nov 27, 2024
@itsyaasir itsyaasir added the No changelog Excludes PR from becoming part of any changelog label Nov 27, 2024
@itsyaasir
Copy link
Contributor Author

Superseded by #1454

@itsyaasir itsyaasir closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working. No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant