Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrow an Identity's ControllerCap in order to perform operations on sub-Identities #1454

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Borrow an Identity's ControllerCap in order to perform operations on sub-Identities #1454

merged 7 commits into from
Nov 27, 2024

Conversation

UMR1352
Copy link
Contributor

@UMR1352 UMR1352 commented Nov 27, 2024

Description of change

Introduces a new proposal type ControllerExecution that allows controllers of Identity A to perform controller-specific operations on Identity B, where A is a controller of B. To achieve this, ControllerExecution lets its executor borrow a specific (selected by its ID) ControllerCap for the duration of the transaction. Move code ensures the borrowed ControllerCap is correctly returned to its place.

Motivation

This is needed in order to enable an "identity owns identity" scenario.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Added an integration test.

@UMR1352 UMR1352 added Enhancement New feature or improvement to an existing feature Added A new feature that requires a minor release. Part of "Added" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. Move Changes to Move packages labels Nov 27, 2024
@UMR1352 UMR1352 self-assigned this Nov 27, 2024
@UMR1352 UMR1352 changed the base branch from main to feat/identity-rebased-alpha November 27, 2024 09:51
@itsyaasir itsyaasir mentioned this pull request Nov 27, 2024
Closed
10 tasks
@UMR1352 UMR1352 marked this pull request as ready for review November 27, 2024 11:15
@UMR1352 UMR1352 requested a review from a team as a code owner November 27, 2024 11:15
@UMR1352 UMR1352 merged commit f5d229a into feat/identity-rebased-alpha Nov 27, 2024
1 check passed
@UMR1352 UMR1352 deleted the feat/borrow-identity-controller-cap branch November 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsyaasir itsyaasir itsyaasir approved these changes

@wulfraem wulfraem wulfraem approved these changes

Assignees

@UMR1352 UMR1352

Labels
Added A new feature that requires a minor release. Part of "Added" section in changelog Enhancement New feature or improvement to an existing feature Move Changes to Move packages Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UMR1352 @wulfraem @itsyaasir