Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iota-data-ingestion-core]: Handle graceful shutdown #4581

Open
sergiupopescu199 opened this issue Dec 20, 2024 · 0 comments · May be fixed by #4648
Open

[iota-data-ingestion-core]: Handle graceful shutdown #4581

sergiupopescu199 opened this issue Dec 20, 2024 · 0 comments · May be fixed by #4648
Assignees
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.

Comments

@sergiupopescu199
Copy link
Contributor

Description

The current implementation of IndexerExecutor attempts to provide graceful shutdown functionality, but it falls short in its execution. While the exit_receiver triggers loop termination, there's missed potential for a more controlled shutdown.

Unused Graceful Shutdown Mechanisms:

  • CheckpointReader offers a dedicated channel for graceful shutdown, but it remains unutilized.
  • Each worker in the WorkerPool possesses a term_receiver intended for graceful shutdown, but its functionality is not yet implemented. Dropping the workers vector doesn't initiate graceful shutdown. The checkpoint synchronization process is particularly sensitive. If a task is interrupted during checkpoint processing, it might not be able to update the progress store, leading to potential issues upon restart. This could result in duplicate checkpoint processing or conflicts in the data, depending on the specific implementation of the worker.
@sergiupopescu199 sergiupopescu199 added infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group. labels Dec 20, 2024
@sergiupopescu199 sergiupopescu199 self-assigned this Dec 20, 2024
@sergiupopescu199 sergiupopescu199 linked a pull request Dec 31, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to the Infrastructure Team sc-platform Issues related to the Smart Contract Platform group.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant